fix(filters): make sort sheet options dense like the other sheets

[richardthe3rd]

Summary

SortOptionsSheet built its options with a plain ListTile and omitted dense: true, while the category, style, and visibility sheets in the same file all pass it on their CheckboxListTiles. With no ListTileTheme anywhere in lib/, the sort tile fell back to the Material 3 default of styling its title from bodyLarge (~16sp) — a 48px row pitch against 40px everywhere else. The result read as a different, larger font in the sort picker.

Adding dense: true brings it in line.

Changes

File	Change
lib/widgets/drink_filter_sheets.dart	dense: true on the ListTile in SortOptionsSheet
test/widgets/drink_filter_sheets_test.dart	Regression test for the row density

On the controlAffinity question in the issue

The issue asked whether the radio-vs-checkbox controlAffinity also wants aligning. It does not: ListTile has no controlAffinity parameter, and passing leading: Radio<DrinkSort>(...) already is leading affinity — consistent with the explicit ListTileControlAffinity.leading on the other sheets. No change made.

Testing

The new test asserts two things: that every sort-option ListTile is dense, and that the rendered height of a sort row equals the rendered height of a category row. The second assertion is deliberately self-calibrating against a sheet that was always dense rather than hardcoding a pixel constant, so it stays honest if Material changes its metrics.

Verified the test is a real guard — with the one-line fix stashed it fails, and passes with it restored:

00:01 +3 -1: SortOptionsSheet option rows are the same height as the other sheets (regression: #507) [E]
  Expected: true
    Actual: <null>

./bin/mise run check is green: 1314 tests pass (baseline 1313), analyzer clean, formatter clean.

Scope notes

• Restyle only — the widget tree shape is unchanged, no restructure mixed in.
• No goldens affected; test/goldens/ covers the brewery, drink-detail, and style screens only, no filter sheets. No golden regeneration was run.
• Semantics wrapper and labels untouched. The issue notes this is cosmetic with no accessibility defect, and that remains true.

Not verifiable by an agent: the visual result in a real browser or on device. Worth a glance at the sort sheet next to the style sheet on the Pages preview.

Fixes #507

---

Generated by Claude Code

[Copilot]

Pull request overview

This PR fixes an inconsistency in the filter bottom sheets by making SortOptionsSheet option rows use the same dense row styling as the category/style/visibility sheets, addressing the “Sort By sheet options render larger” regression (#507).

Changes:

• Set dense: true on the ListTile rows used by SortOptionsSheet.
• Add a widget regression test that verifies the sort sheet rows are dense and match the rendered row height of an already-dense category sheet row.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
lib/widgets/drink_filter_sheets.dart	Makes SortOptionsSheet option rows dense to match other filter sheets’ row density.
test/widgets/drink_filter_sheets_test.dart	Adds a regression test covering both the dense flag and the rendered row height parity with a dense checkbox row.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[github-actions]

🚀 Cloudflare Pages Preview

Your preview deployment is ready!

Preview URL: https://claude-ship-issues-507-0t88t.staging-cambeerfestival.pages.dev

This preview will be automatically updated when you push new commits to this PR.