Skip to content

Conversation

@ChenghaoMou
Copy link
Contributor

This should address #38.

  • added color parsing in both line_to_stream and line_from_stream;
  • added color map for hard-coded highlight and shader colors;
  • added test function and test file for all colors;

Waiting for #39 #41 #42 so some of the tests can be properly run.

@ChenghaoMou ChenghaoMou marked this pull request as ready for review March 16, 2025 16:57
@ricklupton
Copy link
Owner

Thanks @ChenghaoMou -- now that #39, #41 and #42 are merged, from a quick look it looks like one failing test now passes but there are still 2 more failing -- is that something you can check / look into?

@ChenghaoMou
Copy link
Contributor Author

@ricklupton Thanks for the reminder. There was an issue in line_to_stream, but now it's fixed.

@felurx
Copy link

felurx commented Jan 12, 2026

@ricklupton Is there anything holding this back from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants