Upgrade dependencies, target SDK, JVM version#56
Upgrade dependencies, target SDK, JVM version#56ricky9667 merged 12 commits intoricky9667:masterfrom
Conversation
820dc16 to
a3a6be2
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
===========================================
+ Coverage 41.47% 53.15% +11.68%
===========================================
Files 39 39
Lines 1020 999 -21
Branches 283 84 -199
===========================================
+ Hits 423 531 +108
+ Misses 488 432 -56
+ Partials 109 36 -73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the Android project dependencies, target SDK version, and JVM version to modernize the codebase. The primary purpose is to ensure compatibility with newer Android versions and improve development tooling.
- Upgraded target SDK from 35 to 36, minimum SDK from 26 to 29, and JVM from 17 to 21
- Updated key dependencies including Android Gradle Plugin, Compose BOM, Hilt, and various libraries
- Applied consistent code formatting across the codebase with trailing commas and improved indentation using upgraded ktlint
Reviewed Changes
Copilot reviewed 49 out of 50 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/build.gradle.kts | Updated SDK versions, JVM target, and Kotlin compiler configuration |
| gradle/libs.versions.toml | Upgraded dependency versions including Compose BOM, Hilt, and ktlint |
| gradle/wrapper/gradle-wrapper.properties | Updated Gradle version to 8.14.3 |
| .editorconfig | Added configuration to allow Composable function naming conventions |
| Multiple source files | Applied consistent formatting with trailing commas and improved indentation |
| Test files | Added SDK configuration for Robolectric tests |
Comments suppressed due to low confidence (1)
app/build.gradle.kts:50
- The Kotlin Compiler Extension version "1.5.15" appears to be invalid. Compose Compiler versions typically follow a different versioning scheme (e.g., "1.5.8").
kotlinCompilerExtensionVersion = "1.5.15"
ricky9667
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution!
Description
.editorconfigis created for allowing composable function naming pass ktlint style checkAI summary
This pull request introduces several updates to the project, including upgrading dependencies, improving code formatting, and updating configuration files. The key changes are grouped into dependency upgrades, configuration updates, and code formatting improvements.
Dependency and SDK Upgrades:
.github/workflows/build.ymlto 21 and increasedcompileSdk,minSdk, andtargetSdkto 36, 29, and 36 respectively inapp/build.gradle.kts. Also, updated the Kotlin compiler extension version for Compose to 1.5.15. [1] [2] [3]sourceCompatibilityandtargetCompatibilityto Java 21 and added JVM target 21 configuration for Kotlin inapp/build.gradle.kts. [1] [2]Configuration Updates:
.editorconfigfile to enforce consistent code style, including a rule to ignore function naming checks forComposableannotations.tools:targetApiinAndroidManifest.xmlto 36 to align with the newtargetSdkversion.Code Formatting and Refactoring:
HomeScreen.kt,IntroductionScreen.kt,Step1Section.kt,Step2Section.kt, andStep3Section.kt. [1] [2] [3] [4] [5]AppSettingsSerializerandSettingsRepositoryto improve readability and consistency in code style. [1] [2]These changes collectively improve the project's compatibility with newer SDKs, enforce a consistent coding style, and enhance code readability.
Screenshots / Videos