Skip to content

Upgrade dependencies, target SDK, JVM version#56

Merged
ricky9667 merged 12 commits intoricky9667:masterfrom
Xanonymous-GitHub:upgrade-packages
Jul 28, 2025
Merged

Upgrade dependencies, target SDK, JVM version#56
ricky9667 merged 12 commits intoricky9667:masterfrom
Xanonymous-GitHub:upgrade-packages

Conversation

@Xanonymous-GitHub
Copy link
Collaborator

@Xanonymous-GitHub Xanonymous-GitHub commented Jul 13, 2025

Description

  • upgrades project dependencies
  • target sdk version is set to 36
  • JVM version is set to 21
  • ktlint upgraded, so some of files are re-formatted
    • .editorconfig is created for allowing composable function naming pass ktlint style check
  • gradle version upgraded
  • Set RobolectricTestRunner test sdk to 35 (36 hasn't been supported)

AI summary

This pull request introduces several updates to the project, including upgrading dependencies, improving code formatting, and updating configuration files. The key changes are grouped into dependency upgrades, configuration updates, and code formatting improvements.

Dependency and SDK Upgrades:

  • Updated Java version in .github/workflows/build.yml to 21 and increased compileSdk, minSdk, and targetSdk to 36, 29, and 36 respectively in app/build.gradle.kts. Also, updated the Kotlin compiler extension version for Compose to 1.5.15. [1] [2] [3]
  • Set sourceCompatibility and targetCompatibility to Java 21 and added JVM target 21 configuration for Kotlin in app/build.gradle.kts. [1] [2]

Configuration Updates:

  • Added .editorconfig file to enforce consistent code style, including a rule to ignore function naming checks for Composable annotations.
  • Updated tools:targetApi in AndroidManifest.xml to 36 to align with the new targetSdk version.

Code Formatting and Refactoring:

  • Improved code formatting across multiple files by adding trailing commas, aligning modifiers, and breaking long lines for better readability. This includes changes in HomeScreen.kt, IntroductionScreen.kt, Step1Section.kt, Step2Section.kt, and Step3Section.kt. [1] [2] [3] [4] [5]
  • Refactored AppSettingsSerializer and SettingsRepository to improve readability and consistency in code style. [1] [2]

These changes collectively improve the project's compatibility with newer SDKs, enforce a consistent coding style, and enhance code readability.

Screenshots / Videos

Screenshot 2025-07-13 at 4 35 09 PM

@codecov
Copy link

codecov bot commented Jul 27, 2025

Codecov Report

❌ Patch coverage is 47.70642% with 171 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.15%. Comparing base (d57c20c) to head (1b9f0e3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...hkeyboard/keyboard/ui/buttons/NotationKeyButton.kt 35.59% 36 Missing and 2 partials ⚠️
.../rickyhu/hushkeyboard/keyboard/HushKeyboardView.kt 48.78% 17 Missing and 4 partials ⚠️
...rickyhu/hushkeyboard/settings/SettingsViewModel.kt 5.00% 19 Missing ⚠️
.../main/java/com/rickyhu/hushkeyboard/theme/Theme.kt 0.00% 16 Missing ⚠️
...om/rickyhu/hushkeyboard/data/SettingsRepository.kt 0.00% 8 Missing ⚠️
...rickyhu/hushkeyboard/keyboard/KeyboardViewModel.kt 11.11% 8 Missing ⚠️
...c/main/java/com/rickyhu/hushkeyboard/theme/Type.kt 0.00% 8 Missing ⚠️
...hu/hushkeyboard/introduction/IntroductionScreen.kt 0.00% 7 Missing ⚠️
...main/java/com/rickyhu/hushkeyboard/main/MainApp.kt 0.00% 7 Missing ⚠️
...rickyhu/hushkeyboard/data/AppSettingsSerializer.kt 0.00% 6 Missing ⚠️
... and 18 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #56       +/-   ##
===========================================
+ Coverage   41.47%   53.15%   +11.68%     
===========================================
  Files          39       39               
  Lines        1020      999       -21     
  Branches      283       84      -199     
===========================================
+ Hits          423      531      +108     
+ Misses        488      432       -56     
+ Partials      109       36       -73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades the Android project dependencies, target SDK version, and JVM version to modernize the codebase. The primary purpose is to ensure compatibility with newer Android versions and improve development tooling.

  • Upgraded target SDK from 35 to 36, minimum SDK from 26 to 29, and JVM from 17 to 21
  • Updated key dependencies including Android Gradle Plugin, Compose BOM, Hilt, and various libraries
  • Applied consistent code formatting across the codebase with trailing commas and improved indentation using upgraded ktlint

Reviewed Changes

Copilot reviewed 49 out of 50 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
app/build.gradle.kts Updated SDK versions, JVM target, and Kotlin compiler configuration
gradle/libs.versions.toml Upgraded dependency versions including Compose BOM, Hilt, and ktlint
gradle/wrapper/gradle-wrapper.properties Updated Gradle version to 8.14.3
.editorconfig Added configuration to allow Composable function naming conventions
Multiple source files Applied consistent formatting with trailing commas and improved indentation
Test files Added SDK configuration for Robolectric tests
Comments suppressed due to low confidence (1)

app/build.gradle.kts:50

  • The Kotlin Compiler Extension version "1.5.15" appears to be invalid. Compose Compiler versions typically follow a different versioning scheme (e.g., "1.5.8").
        kotlinCompilerExtensionVersion = "1.5.15"

Copy link
Owner

@ricky9667 ricky9667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@ricky9667 ricky9667 merged commit ed5f797 into ricky9667:master Jul 28, 2025
3 checks passed
@Xanonymous-GitHub Xanonymous-GitHub deleted the upgrade-packages branch July 28, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants