Skip to content

Fix Assembler Warning: mnemonic suffix used with `div' #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Fix Assembler Warning: mnemonic suffix used with `div' #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2135c35
Fix "Warning: mnemonic suffix used with `div'"
kimwalisch Mar 31, 2025
bf6f158
Disable broken MSVC sanitize tests on Windows
kimwalisch Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/full_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ jobs:
- windows-2019
build_type:
- Release
- Sanitize
cpp_compiler:
- clang-cl.exe
- cl.exe
Expand All @@ -84,10 +83,6 @@ jobs:
# clang-cl requires the toolset flag be set correctly
- cpp_compiler: clang-cl.exe
toolset: ClangCL
exclude:
# MSVC Clang toolchain fails sanitization
- cpp_compiler: clang-cl.exe
build_type: Sanitize

env:
output_folder: ${{github.workspace}}/build/
Expand Down
2 changes: 1 addition & 1 deletion libdivide.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ static LIBDIVIDE_INLINE uint64_t libdivide_128_div_64_to_64(
// it's not LIBDIVIDE_INLINEd.
#if defined(LIBDIVIDE_X86_64) && defined(LIBDIVIDE_GCC_STYLE_ASM)
uint64_t result;
__asm__("divq %[v]" : "=a"(result), "=d"(*r) : [v] "r"(den), "a"(numlo), "d"(numhi));
__asm__("div %[v]" : "=a"(result), "=d"(*r) : [v] "r"(den), "a"(numlo), "d"(numhi));
return result;
#else
// We work in base 2**32.
Expand Down