Skip to content

Simplify LIBDIVIDE_CONSTEXPR check #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

pps83
Copy link
Contributor

@pps83 pps83 commented Apr 3, 2025

No description provided.

@pps83
Copy link
Contributor Author

pps83 commented Apr 3, 2025

the comment for msvc could be simplified imo: msvc used to define __cplusplus to some ancient values even when compiling with c++14 / c++17 because they didn't have fully implemented these standards. For that reason, they had _MSVC_LANG that identifies that "incomplete" c++ version that was being targeted. Afaik, for newer version that's not needed and they properly define __cplusplus version and feature test macros. I would just put this way:

// Older msvc versions might need to check _MSVC_LANG instead of `__cpp_constexpr`

here's the info from them: https://developercommunity.visualstudio.com/t/-cplusplus-macro-is-wrong/169519#T-N223875
https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/

@kimwalisch kimwalisch merged commit 99fad03 into ridiculousfish:master Apr 4, 2025
16 checks passed
@pps83 pps83 deleted the simpler-constexpr branch April 4, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants