Add missing function specifiers to match their declaration#143
Merged
kimwalisch merged 1 commit intoridiculousfish:masterfrom Apr 4, 2025
Merged
Add missing function specifiers to match their declaration#143kimwalisch merged 1 commit intoridiculousfish:masterfrom
kimwalisch merged 1 commit intoridiculousfish:masterfrom
Conversation
All these function are declared with `static LIBDIVIDE_INLINE`, but do not have them at definition
Collaborator
|
@pps83 Some of the libdivide vector functions definitions are still not marked as static inline... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All these functions are declared with
static LIBDIVIDE_INLINE, but do not have them at definition