Skip to content

Disable Linq.Expression preferInterpretation for bindings #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
exyi merged 1 commit into from
Jan 31, 2024
Merged

Disable Linq.Expression preferInterpretation for bindings #1768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Framework/Framework/Binding/IExpressionToDelegateCompiler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ public DefaultExpressionToDelegateCompiler(DotvvmConfiguration config)
interpret = config.Debug;
}
public Delegate Compile(LambdaExpression expression) =>
interpret ? expression.Compile(preferInterpretation: interpret) :
// the interpreter is broken: https://github.com/dotnet/runtime/issues/96385
// interpret ? expression.Compile(preferInterpretation: interpret) :
expression.Compile();
// TODO: use FastExpressionCompiler
// we can't do that atm since it still has some bugs, when these are fixed we should use that for all bindings
Expand Down