Disable lambda conversion in normal bindings #1928
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In command bindings, expressions get automatically wrapped in a lambda function. Surprisingly, the behavior was also present in value/resource, which lead to some surprising effects when value/resource was accidentally assigned to a command property (#1742). We also unify that untyped ICommandBinding and IStaticCommandBinding produce delegate of type Command (i.e. async function with no argument and no return value). Previously Delegate was used for commands, which had the effect of sending the return value to the client
There was a problem hiding this comment.
Pull Request Overview
This PR disables implicit lambda conversion in value/resource bindings while unifying command bindings to produce a Command delegate. Key changes include:
- Updating tests to verify that value bindings no longer perform lambda conversion.
- Refactoring binding helper methods by introducing a CreateBinding function and a new BindingType enum.
- Adjustments in GeneralBindingPropertyResolvers, StaticCommandBindingExpression, and CommandBindingExpression to align with the new conversion behavior and syntax updates.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Tests/Binding/BindingCompilationTests.cs | Updated test methods to cover both Command and StaticCommand bindings and added a test to enforce that value bindings cannot perform lambda conversion. |
| src/Framework/Testing/BindingTestHelper.cs | Introduced CreateBinding and a BindingType enum; refactored ExecuteBinding to use new array literal syntax for view model stack. |
| src/Framework/Framework/Compilation/Binding/GeneralBindingPropertyResolvers.cs | Removed fallback to MagicLambdaConversion for value/resource bindings to disable lambda conversion. |
| src/Framework/Framework/Binding/Expressions/StaticCommandBindingExpression.cs | Updated the syntax for GetResolvers using new array literal and spread operator syntax in line with language updates. |
| src/Framework/Framework/Binding/Expressions/CommandBindingExpression.cs | Enhanced GetResolvers by combining common command methods with specific methods and updated command type conversion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In command bindings, expressions get automatically wrapped in a lambda function. Surprisingly, the behavior was also present in value/resource, which lead to some surprising effects when value/resource was accidentally assigned to a command property (#1742).
We also unify that untyped ICommandBinding and IStaticCommandBinding produce delegate of type Command (i.e. async function with no argument and no return value). Previously Delegate was used for commands,
which had the effect of sending the return value to the client