Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 5, 2025

New control similar to ValidationSummary that displays only the count of validation errors in the current Validation.Target.

Changes

  • ValidationErrorsCount.cs - New control with:

    • IncludeErrorsFromChildren (default: true) - count errors from nested objects
    • IncludeErrorsFromTarget (default: true) - count errors from target itself
    • InvalidCssClass - CSS class applied when errors exist
    • WrapperTagName (default: span) - customizable wrapper tag
  • validation.ts - Added dotvvm-validationErrorsCount Knockout binding handler

Usage

<!-- Basic -->
<dot:ValidationErrorsCount />

<!-- With target and invalid class -->
<dot:ValidationErrorsCount Validation.Target={value: Person} InvalidCssClass="has-errors" />

<!-- Custom wrapper -->
<dot:ValidationErrorsCount WrapperTagName="div" />

<!-- Only target errors, no children -->
<dot:ValidationErrorsCount IncludeErrorsFromChildren="false" />

Note: IncludeErrorsFromChildren defaults to true (unlike ValidationSummary which defaults to false) per the issue requirements.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 0t3vsblobprodcus362.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
  • 1p7vsblobprodcus324.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
  • 1s1vsblobprodcus386.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/Samples/Tests/CompletenessChecker/DotVVM.Samples.Tests.CompletenessChecker.csproj --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l /Resources/Scrip-exec sts.cs cal/bin/grep (dns block)
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/Samples/Tests/Tests/DotVVM.Samples.Tests.csproj --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep orking/emptyFakeDotnetRoot working/emptyFakeDotnetRoot gCompilationTests.cs rgo/bin/grep (dns block)
  • 4m6vsblobprodcus384.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
  • 7devsblobprodcus323.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/00DA3BA51762B14D47D4C9F6E8A232CB/missingpackages_workingdir --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force -l testoutputs/ValidationErrorsCountTests.ValidationErrorsCount_WithValidationDisabled.html sts.cs rep (dns block)
  • cflvsblobprodcus383.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/Samples/Tests/CompletenessChecker/DotVVM.Samples.Tests.CompletenessChecker.csproj --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l /Resources/Scrip-exec sts.cs cal/bin/grep (dns block)
  • jd4vsblobprodcus366.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
  • k4kvsblobprodcus344.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
  • m6xvsblobprodcus342.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
  • pdfvsblobprodcus380.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
  • pe3vsblobprodcus354.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
  • yttvsblobprodcus357.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>ValidationErrorsCount control</issue_title>
<issue_description>I need a control with a logic similar to ValidationSummary, but which would print only the count of validation errors in the current Validation.Target.
By default, it should include errors from the target and its children.
It should also have the InvalidCssClass property that would be applied on the element (specified in WrapperTagName - span by default) when there is at least one error.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits December 5, 2025 16:07
- Create ValidationErrorsCount.cs control that displays validation error count
- Support for IncludeErrorsFromChildren and IncludeErrorsFromTarget properties
- Support for InvalidCssClass property to apply CSS class when errors exist
- Support for WrapperTagName property (default: span)
- Add JavaScript binding handler in validation.ts
- Add unit tests for the new control

Co-authored-by: tomasherceg <[email protected]>
- Add initial execution of updateErrorCount in JS to show count immediately
- Add documentation clarifying IncludeErrorsFromChildren default differs from ValidationSummary

Co-authored-by: tomasherceg <[email protected]>
Copilot AI changed the title [WIP] Add validation errors count control Add ValidationErrorsCount control Dec 5, 2025
Copilot AI requested a review from tomasherceg December 5, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ValidationErrorsCount control

2 participants