CI: test with pathbase#2031
Open
exyi wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for running the ASP.NET Core sample apps (and corresponding UI tests) under a non-root PathBase, to validate DotVVM works correctly when hosted behind a base path.
Changes:
- Add optional
DOTVVM_TEST_PATH_BASEhandling inAspNetCoreLatestsample startup to enforce a mandatory base path during CI runs. - Extend the UI test GitHub Action to accept a
path-baseinput and pass it through to test scripts. - Update the Linux UI test runner script to probe the app under the base path and rewrite
seleniumconfig.jsonbase URLs accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Samples/AspNetCoreLatest/Startup.cs |
Adds middleware to apply/enforce a mandatory PathBase for CI path-base testing. |
.github/workflows/main.yml |
Introduces path-base as a UI test matrix dimension and passes it into the UI test action. |
.github/uitest/uitest.sh |
Updates sample readiness probing and selenium config base URL rewriting to include the optional path base. |
.github/uitest/action.yml |
Adds path-base input and exports it as DOTVVM_TEST_PATH_BASE for both bash and pwsh runs. |
Comments suppressed due to low confidence (2)
.github/workflows/main.yml:204
- The matrix defines
path-base, but thisincludeentry doesn’t specify it. In GitHub Actions, included matrix rows can end up without the key, and${{ matrix.path-base }}later may fail/resolve to null. Addpath-base: ""to this and the other include entries that don’t override it.
path-base: [""]
include:
- browser: chrome
os: windows-2022
environment: Development
.github/workflows/main.yml:215
- This
includeentry (and others below) doesn’t setpath-base, butmatrix.path-baseis referenced later. Ensure every included row setspath-base(typically to "") so the matrix variable is always defined.
- browser: firefox
os: ubuntu-latest
environment: Production
samples-config: Default
- browser: firefox
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+152
to
+154
| function wait_sample { | ||
| PORT=$1 | ||
| PATH_BASE=$2 |
05cb970 to
72e3fad
Compare
ActiveTab switching could get reverted by a postback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.