Fix otel propagation #544
Merged
Fix otel propagation #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichulburd
force-pushed
the
fix-otel-propagation
branch
from
039da33 to
ec9fe89
Compare
|
Contributor
|
@erichulburd I reviewed the code and all looks good - I like the test setup - but can we get a PR description and linked issue? There's no context here, for now or later |
erichulburd
commented
Mar 24, 2025
gsmith-rigetti
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #545 .
This fix:
py_function_sync_asynchere so that we can callopentelemetry::trace::FutureExt::with_current_contexton the top-level future. See issue for additional details.