Feature/update gapi client #82
Conversation
Add Cinch's rate limiting configuration options
|
Going to wait to merge this until i can find a chance to test it |
|
I should also note that I was only able to upgrade to 0.10.x because 0.11.x depends on It seems as though a newer version of |
|
Mail is used in the backup scripts, which is actually code that has never been touched, and currently not actively used, at least by me. It's defined in the Gemfile & you can look at the gemfile.lock to see what is requiring something. 👍 TL;DR if it's not defined in the gemfile explicitly, it's pulled in as a dependency. If you're wanting to/up for doing an update of the gemfile dependencies (and perhaps removing some of the hard versions defined as a bonus), i would certainly not object, it's just a bit time-consuming to update and figure out if anything breaks. :) |
|
That's something I'll definitely consider doing, but I agree that it will be time consuming and somewhat tedious. It might also be worthwhile to go through the entire project to delete code and dependencies that are unused. Less code, fewer bugs! This seems like something that deserves it's own issue. |
|
Honestly, the back of stuff is the only code that is completely unused as far as I remember, and that's mostly just unused because I haven't gotten around to using it rather than because it is useless but I agree, definitely is a separate issue |
…lier versions don't work with cinchize
…e those should respond ASAP
|
Hm, how would you feel about updating this to 0.11 regardless, making a note for later testing/a FIXME in the backup code/the commit message? Since it's code that's not actively used, i don't mind breaking it for the sake of updating code that is actively used and fixing it later when we actually have the time and need it. 👍 |
Add's cooldown support via cinch-cooldown Closes rikai#40
|
I'll hunt down the backup code and see how it uses |
This is just hooking the discordrb bot into the showbot startup process and implementing a minimal bot setup
This commit provides a working Travis CI configuration file; however, builds currently fail because, well, the test suite isn't in great shape.
…the build status badge
Add .travis.yml
Update Gemfile.lock to satisfy Travis
This commit provides a working Travis CI configuration file; however, builds currently fail because, well, the test suite isn't in great shape.
…the build status badge
…e business logic from the model.
More testing and actually get travis building
|
I just started digging into how the backup feature is supposed to work. It actually looks pretty useful! (For reference, here is the documentation). Is having backups of Showbot's database useful to JB, or are you backing the Showbot droplet up in a different way? Currently, the backup code you said that you don't use is configured to back up the MySQL database to Amazon S3, provided that it has all of the information required to access the database and upload to an S3 bucket. I don't see any issues that would prevent me from simply removing the version restriction and updating the |
…e all the way to v13
…e all the way to v13
|
I rebased on |
Resolves #73, as long as someone tests it with JBot's API key first to make sure I didn't accidentally break something I can't test…