-
Notifications
You must be signed in to change notification settings - Fork 129
refactor (state management): Remove extra layer when mapping URL parameters to Explore state #7086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This sadly conflicts heavily with #7062. I am getting rid of the intermediate step in there already. This would be redundant. |
Nice to see that! Just this is the kind of thing that should be a standalone PR. Do you want to split your work out into a dedicated PR or should I get this one over-the-line? |
…e-translation-layer
In our current state mapping flow, we convert
URLSearchParams
→V1ExplorePreset
→MetricsExplorerEntity
. The intermediateV1ExplorePreset
layer is unnecessary and adds complexity.This PR removes the extra layer, directly mapping
URLSearchParams
toMetricsExplorerEntity
.Note: This PR doesn’t much cleanup the state mapping logic itself, but it simplifies the flow and sets us up for future cleanup.
Builds on #7084, #7087
Checklist: