Skip to content

feat: dark mode scaffolding #7156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: dark mode scaffolding #7156

wants to merge 25 commits into from

Conversation

briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Apr 15, 2025

  • Add feature flag darkMode
  • Refine theme palette generation
  • Remove transition-colors class
  • Remove explicit border-gray-200 classes
  • Cleanup tailwind config
  • Convert bg-white usage to bg-surface
  • Add node script to generate colors.css file with necessary mappings
  • Remove RillTheme component
  • Upgrade chroma-js
  • Add dark variation to code editor
  • Create new theme Tailwind color, falling back to primary when not set

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@briangregoryholmes briangregoryholmes self-assigned this Apr 15, 2025
@briangregoryholmes briangregoryholmes added the Team:Applications Applications Working Group label Apr 15, 2025
Copy link

Dark Mode

@briangregoryholmes briangregoryholmes changed the title feat: dark mode feat: dark mode scaffolding Apr 22, 2025
@briangregoryholmes briangregoryholmes marked this pull request as ready for review April 22, 2025 02:48
@ericpgreen2
Copy link
Contributor

Generally looking good! I started a UXQA doc here with a couple initial observations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Applications Applications Working Group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants