Validate consistent time settings in Canvas across dependent metrics views #7192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository not enabled for automatic reviewThe Bito agent is set up, but this repository is not enabled for automatic code reviews. To review this pull request, type You can enable automatic reviews in the agent setup here or contact your Bito workspace admin at [email protected].
|
begelundmuller
requested changes
Apr 24, 2025
runtime/server/canvases.go
Outdated
Comment on lines
146
to
148
| // Validate all metrics views have consistent first_day_of_week or first_month_of_year | ||
| // This ensures that time-based aggregations across different metrics views are consistent | ||
| if len(metricsViews) > 0 { |
There was a problem hiding this comment.
The validation needs to go in runtime/reconcilers/canvas.go so that it runs as part of reconciliation/validation, not on every load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves: https://github.com/rilldata/rill-private-issues/issues/1549 Which validates all metrics views used in a canvas have the same
first_day_of_weekandfirst_month_of_yearChecklist: