[PLAT-303] use time spine for timeseries #8379
Open
+574
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| require.Equal(t, 3.0, tr.Data[2].Records.Fields["measure_2"].GetNumberValue()) | ||
|
|
||
| server, instanceId = getMetricsTestServerWithInstanceConfigs(t, "ad_bids", map[string]string{ | ||
| "rill.metrics.timeseries_null_filling_implementation": "pushdown", |
Contributor
There was a problem hiding this comment.
If you change this to be the default, does all the old tests pass?
Member
Author
There was a problem hiding this comment.
I have not changed the default in code so all old tests are still passing and in this test above server is created without the new config and that has same results as this one. I added these tests just to show that results with old and new config are still same and no behaviour change happened.
Contributor
There was a problem hiding this comment.
What I mean is just if you change the default to pushdown on your local (but don't push the change as we don't want to change the default in prod yet) and run the timeseries tests locally, do they pass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its still not enabled by default. I think we should initially enable it with config
rill.metrics.timeseries_null_filling_implementation: pushdownfor selected projects backed by different olaps. If things go fine then in the next version we can make it default.Checklist: