Skip to content

Conversation

@lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Nov 24, 2025

This PR addresses a race condition that could create duplicate connector files (e.g., clickhouse.yaml and clickhouse_1.yaml) when users interact with the "Test and Connect" and "Save Anyway" flows for connector creation.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@lovincyrus lovincyrus requested a review from royendo November 24, 2025 19:34
@lovincyrus lovincyrus self-assigned this Nov 24, 2025
Copy link
Contributor

@royendo royendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cross posting,

still seeing strange behavior on different runs.

atm, it builds a single file but returning to the add clickhouse connector, unable to test and connect.

Other times i get a loading circle for both and takes a bit for save anyways to get triggered.

https://jam.dev/c/12a8371a-d266-4fad-a1b4-04343e209681

@lovincyrus lovincyrus closed this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants