Skip to content

fix: close watcher in file driver #8616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
begelundmuller merged 1 commit into from
Jan 9, 2026
Merged

fix: close watcher in file driver #8616

begelundmuller merged 1 commit into from
Jan 9, 2026

Conversation

@k-anshul
Copy link
Member

@k-anshul k-anshul commented Jan 9, 2026 •
edited
Loading

INSERT DESCRIPTION HERE

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul self-assigned this Jan 9, 2026
begelundmuller
begelundmuller approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begelundmuller begelundmuller merged commit 5e14779 into main Jan 9, 2026
15 checks passed
@begelundmuller begelundmuller deleted the close_watcher_file_driver branch January 9, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@begelundmuller begelundmuller begelundmuller approved these changes

Assignees

@k-anshul k-anshul

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@k-anshul @begelundmuller