Draft
Conversation
Adds an inline theme editor to the explore and canvas dashboard inspectors. Users can adjust the dashboard theme directly from the inspector, with live preview powered by a `themePreviewOverride` store that the dashboard wrappers read from. Includes the visual-editing primitives the inspectors depend on (`ThemeInput`, `ThemePropertySections`, `theme-editor-store`, `theme-yaml-utils`, `theme-property-config`).
Inline theme editor's `Presets` view now shows the resolved theme's colors in a read-only state, with an `Edit theme file` button that opens the underlying YAML file in the editor. Property edits are only accepted in `Custom` mode, which writes back to the dashboard YAML.
royendo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken off #8511,
This should be a great feature for rill cloud editing not having to edit a #00ff32 YAML file and do it in-line with Dashboard.
Discussed with Di in the past and came to this design, tagging for final approval
Checklist: