feat: Add percentMode config and improve percentage formatting for funnel charts#9341
Open
feat: Add percentMode config and improve percentage formatting for funnel charts#9341
percentMode config and improve percentage formatting for funnel charts#9341Conversation
Contributor
|
cc @Di7design for design review |
ericokuma
requested changes
Apr 30, 2026
royendo
added a commit
that referenced
this pull request
May 1, 2026
PR #9341 adds a section-scoped loader that redirects branch-view URLs to branch home and gates production view on `manageProject`. When that PR lands first, the Status tab (now visible to editors per this PR) would dead-end at a 403/redirect for editors and on any branch URL. Override the loader to gate on `readProdStatus` and drop the branch-view redirect so editors can reach Status from any URL. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
begelundmuller
approved these changes
May 4, 2026
Contributor
begelundmuller
left a comment
begelundmuller
left a comment
There was a problem hiding this comment.
Backend looks good
See reference link below: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
percentMode(top|previous, defaulttop) to funnel chart spec so authors can pick whether on-bar percentages reference the top of the funnel or the previous stage.% of topand% of previousregardless of the configured mode, so end-users can disambiguate without the author surfacing both..0stripped (32%,32.1%) so neighboring values stay visually distinct while round numbers stay clean.Closes https://linear.app/rilldata/issue/APP-821/canvas-funnel-chart-percentage-ambiguous-add-reference-label-decimal
Checklist: