Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update librime to 1.11.0 #860

Merged
merged 2 commits into from
Apr 15, 2024
Merged

deps: update librime to 1.11.0 #860

merged 2 commits into from
Apr 15, 2024

Conversation

ksqsf
Copy link
Member

@ksqsf ksqsf commented Apr 15, 2024

Previously, action-install.sh was not updated accordingly, and the build artifact is completely unusable: it will always crash.

Also add a xcode build phase to copy official plugins. The build artifact should be fully functional now.

@ksqsf ksqsf changed the title chore: upgrade to librime 1.11.0 deps: update librime to 1.11.0 Apr 15, 2024
@ksqsf ksqsf marked this pull request as draft April 15, 2024 05:58
@ksqsf ksqsf marked this pull request as ready for review April 15, 2024 06:20
@ksqsf ksqsf merged commit 282c722 into master Apr 15, 2024
2 checks passed
@lotem
Copy link
Member

lotem commented Apr 15, 2024

本地编译没带插件怎么办呢。

@lotem
Copy link
Member

lotem commented Apr 15, 2024

要想兼容构建不同插件的情况,得借鉴自带yaml文件的做法,用脚本往Xcode配置里添加文件。

@ksqsf
Copy link
Member Author

ksqsf commented Apr 15, 2024

make release 应该会自动拷贝插件吧。copy-rime-binaries 把 rime-plugins 从 librime/dist/lib 拷贝到 ./lib,然后 xcodebuild 再拷贝到 build/Release/Squirrel.app

@ksqsf
Copy link
Member Author

ksqsf commented Apr 15, 2024

尴尬,不懂 Xcode……用脚本添加的话我再看看怎么搞。

@ksqsf
Copy link
Member Author

ksqsf commented Apr 15, 2024

看了下,SharedSupport 的文件也是硬编码的……

https://github.com/rime/squirrel/blob/master/Squirrel.xcodeproj/project.pbxproj#L145

@ksqsf ksqsf deleted the librime-1.11 branch April 15, 2024 07:46
@lotem
Copy link
Member

lotem commented Apr 15, 2024

哦。看来数据文件改成硬编码了。以前是用一个shell脚本给plum下载的每个文件生成一项Xcode配置,UUID自己算,递增。可能有人觉得这样不太可靠。

@lotem
Copy link
Member

lotem commented Apr 15, 2024

要不然给本地构建也加上那几个插件?

@lotem
Copy link
Member

lotem commented Apr 15, 2024

行。就这样吧。以后给Makefile改改。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants