Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no default plugins included #928

Closed
wants to merge 1 commit into from
Closed

no default plugins included #928

wants to merge 1 commit into from

Conversation

yakirChen
Copy link

No description provided.

@ksqsf
Copy link
Member

ksqsf commented Jun 4, 2024

IMHO This will break the default make package and make archive.

LEOYoon-Tsaw
LEOYoon-Tsaw requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@LEOYoon-Tsaw LEOYoon-Tsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in package/add_data_files librime-lua is used as an anchor for other plugins, need to find a new anchor if by default there's no plugin

@yakirChen yakirChen closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LEOYoon-Tsaw LEOYoon-Tsaw LEOYoon-Tsaw requested changes

@ksqsf ksqsf Awaiting requested review from ksqsf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yakirChen @ksqsf @LEOYoon-Tsaw