Skip to content

fix(RimeWithWeasel): avoid vim_mode misoperations #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fxliang merged 2 commits into from
Mar 26, 2025
Merged

fix(RimeWithWeasel): avoid vim_mode misoperations #1543

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1487ddb
fix(RimeWithWeasel): avoid vim_mode misoperations
fxliang Mar 24, 2025
49d5ba2
refactor: move KeyEvent.h to include and move KeyInfo to KeyEvent.h
fxliang Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion RimeWithWeasel/RimeWithWeasel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,8 @@ BOOL RimeWithWeaselHandler::ProcessKeyEvent(KeyEvent keyEvent,
RimeSessionId session_id = to_session_id(ipc_id);
Bool handled = rime_api->process_key(session_id, keyEvent.keycode,
expand_ibus_modifier(keyEvent.mask));
if (!handled) {
// vim_mode when keydown only
if (!handled && !(keyEvent.mask & (1 << 14))) {
Comment thread
fxliang marked this conversation as resolved.
Outdated
bool isVimBackInCommandMode =
(keyEvent.keycode == ibus::Keycode::Escape) ||
((keyEvent.mask & (1 << 2)) &&
Expand Down