Skip to content

feat: add database indexes to assessment_attempt for common query paths #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RUKAYAT-CODER merged 1 commit into from
Aug 29, 2026
Merged

feat: add database indexes to assessment_attempt for common query paths #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/assessment/entities/assessment-attempt.entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ import {
PrimaryGeneratedColumn,
Column,
ManyToOne,
JoinColumn,
OneToMany,
VersionColumn,
Index,
} from 'typeorm';
import { AssessmentStatus } from '../enums/assessment-status.enum';
import { Answer } from './answer.entity';
Expand All @@ -14,6 +16,10 @@ import { Assessment } from './assessment.entity';
* Represents the assessment Attempt entity.
*/
@Entity()
@Index('IDX_assessment_attempt_studentId', ['studentId'])
@Index('IDX_assessment_attempt_assessmentId', ['assessmentId'])
@Index('IDX_assessment_attempt_status', ['status'])
@Index('IDX_assessment_attempt_studentId_assessmentId', ['studentId', 'assessmentId'])
export class AssessmentAttempt {
@PrimaryGeneratedColumn('uuid')
id: string;
Expand All @@ -25,8 +31,12 @@ export class AssessmentAttempt {
studentId: string;

@ManyToOne(() => Assessment)
@JoinColumn({ name: 'assessmentId' })
assessment: Assessment;

@Column({ name: 'assessmentId', type: 'uuid', nullable: true })
assessmentId: string | null;

@Column({ type: 'enum', enum: AssessmentStatus })
status: AssessmentStatus;

Expand Down
34 changes: 34 additions & 0 deletions src/migrations/1802000000000-add-assessment-attempt-indexes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import { MigrationInterface, QueryRunner } from 'typeorm';

/**
* Issue #1229 — assessment_attempt has no indexes beyond the primary key.
*
* Common query paths that need coverage:
* - "list my attempts" → WHERE "studentId" = $1
* - "attempts for assessment" → WHERE "assessmentId" = $1 (FK column)
* - "filter by status" → WHERE status = $1
* - "has student started this assessment?" → WHERE "studentId" = $1 AND "assessmentId" = $2
*/
export class AddAssessmentAttemptIndexes1802000000000 implements MigrationInterface {
public async up(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(
'CREATE INDEX IF NOT EXISTS "IDX_assessment_attempt_studentId" ON "assessment_attempt" ("studentId")',
);
await queryRunner.query(
'CREATE INDEX IF NOT EXISTS "IDX_assessment_attempt_assessmentId" ON "assessment_attempt" ("assessmentId")',
);
await queryRunner.query(
'CREATE INDEX IF NOT EXISTS "IDX_assessment_attempt_status" ON "assessment_attempt" ("status")',
);
await queryRunner.query(
'CREATE INDEX IF NOT EXISTS "IDX_assessment_attempt_studentId_assessmentId" ON "assessment_attempt" ("studentId", "assessmentId")',
);
}

public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query('DROP INDEX IF EXISTS "IDX_assessment_attempt_studentId_assessmentId"');
await queryRunner.query('DROP INDEX IF EXISTS "IDX_assessment_attempt_status"');
await queryRunner.query('DROP INDEX IF EXISTS "IDX_assessment_attempt_assessmentId"');
await queryRunner.query('DROP INDEX IF EXISTS "IDX_assessment_attempt_studentId"');
}
}
Loading