fix(courses): add currency column to Course entity to match migration - #1413
Open
sadiqabubakar826-del wants to merge 1 commit into
Open
Conversation
Migration 1685000001001-add-currency-field-to-courses adds a varchar(3) currency column with DEFAULT 'USD' and index IDX_course_currency to the course table. Declare the matching @column and @Index on the Course entity so TypeORM can use multi-currency pricing and the drift checker no longer tries to drop the column (closes rinafcode#1194).
|
@sadiqabubakar826-del Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Well done on the job done so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a PR description you can use:
───────────────────────────────────────────────────────────────────────────────────────────────
fix(courses): declare currency column on Course entity (#1194)
Problem
Migration 1685000001001-add-currency-field-to-courses adds a currency varchar(3) DEFAULT 'USD'
column and IDX_course_currency index to the course table, but the Course entity had no
corresponding @column declaration. This caused two issues:
invisible to the ORM
Reconcile entity/migration drift so the schema drift check passes strictly #1194)
Fix
Added the missing currency field to src/courses/entities/course.entity.ts:
/** ISO 4217 currency code for the course price (e.g. 'USD', 'EUR'). */
@Index('IDX_course_currency')
@column({ type: 'varchar', length: 3, nullable: true, default: 'USD' })
currency?: string;
The declaration matches the migration exactly:
than creating a duplicate or dropping it
No migration needed — the column already exists in the database. This is an entity-only fix to
bring the ORM in sync with the schema.
Testing
Closes #1205
Closes #1204