fix: add getItemLayout to FlatLists for virtualization performance - #691
Merged
RUKAYAT-CODER merged 3 commits intoJun 26, 2026
Merged
Conversation
Adds getItemLayout prop with estimated item heights to all FlatLists in the project that were missing it, enabling proper windowed virtualization: - MobileSearch.tsx (course search results): 120px item height - ConnectionManager.tsx (connections): 65px item height - DownloadQueue.tsx (download tasks): 80px item height - AdvancedDataGrid.tsx (data rows): 40px item height Without getItemLayout, FlatList cannot use windowed virtualization and must measure every item to determine scroll offsets, which breaks performance for large datasets.
|
@oluwaseyi1996-netizen Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Add KeyboardAvoidingView mock with displayName to jest.setup.js - Add @sentry/react-native mock to jest.setup.js - Fix secureStorage test mocks to properly handle read-write verification cycle - Fix logging test expectation to match actual log signature - Fix beforeEach blocks to use resetAllMocks for clean mock state
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
getItemLayoutprop with estimated item heights to all FlatLists in the project that were missing it, enabling proper windowed virtualization.Changes
Why
Without getItemLayout, React Native FlatList cannot use windowed virtualization and must measure every item to determine scroll offsets. This breaks performance for large datasets.
With getItemLayout, FlatList calculates exact offsets by index, enabling efficient rendering of only visible items and smooth scrolling with large datasets.
Testing
Closes #608