chore: remove unused ethers dependency and dead service code - #1332
Merged
Conversation
Nothing in the application imports ethersService or serviceAccount; the ethers package was only referenced by its own tests. On-chain actions are mediated by the backend and the Stellar/Soroban contract, so the EVM-oriented ethers library is unused. - Delete src/services/ethersService.ts and src/services/serviceAccount.ts and their test files. - Drop the ethers dependency from package.json and refresh pnpm-lock.yaml. - Remove leftover ethers references in next.config.ts (optimizePackageImports and the webpack splitChunks cache group).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused
ethersdependency and its dead service modules.Why
ethersServiceandserviceAccountare not imported anywhere in the app — only their own tests referenced them. TeachLink settles on-chain actions through the backend and the Stellar/Soroban contract, so the EVM-orientedetherslibrary is unused. Removing it trims install size and reduces dependency-audit noise.What changed
src/services/ethersService.ts,src/services/serviceAccount.ts, and their test files.ethersfrompackage.jsonand refreshedpnpm-lock.yaml(removes ethers and its exclusive transitive deps only).ethersreferences innext.config.ts(optimizePackageImportsentry and the webpacksplitChunkscache group).No application code imports the removed modules, so behavior is unchanged.
closes #1331