Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better: Allow to filter by sources type RD-29241 #249

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Better: Allow to filter by sources type RD-29241 #249

wants to merge 10 commits into from

Conversation

GCorbel
Copy link
Contributor

@GCorbel GCorbel commented Jun 5, 2024

This adds the documentation for the new type parameter for the content-sources endpoint.

@GCorbel GCorbel requested a review from FabienChaynes June 5, 2024 21:32
@GCorbel GCorbel marked this pull request as draft June 5, 2024 21:49
@GCorbel
Copy link
Contributor Author

GCorbel commented Jun 5, 2024

I mark the PR as a draft as I have some trouble with the CI

@GCorbel GCorbel force-pushed the filter-type-gco branch from b9fd1f2 to 2315d8a Compare June 6, 2024 14:22
@GCorbel GCorbel changed the base branch from master to update-go-version June 6, 2024 14:23
@GCorbel GCorbel changed the base branch from update-go-version to fix-go-version-gco June 6, 2024 14:23
@GCorbel GCorbel marked this pull request as ready for review June 6, 2024 14:25
@GCorbel GCorbel changed the base branch from fix-go-version-gco to master June 7, 2024 17:31
@GCorbel
Copy link
Contributor Author

GCorbel commented Jun 20, 2024

@jiop can you take a look at this PR ? I can't change the reviewers.

FabienChaynes
FabienChaynes reviewed Jul 24, 2024
View reviewed changes
specs/engage-digital_openapi3.yaml
name: type
required: false
schema:
type: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably add an enum with the list of accepted types (like what we do for permissions).

@DrissTM
Copy link
Contributor

DrissTM commented Mar 7, 2025

@GCorbel what's happening with this PR?

@GCorbel
Copy link
Contributor Author

GCorbel commented Mar 7, 2025

I don't have the permission to merge PRs. I take a look at the Fabien's comment.

@GCorbel
Copy link
Contributor Author

GCorbel commented Mar 7, 2025

It looks like I don't have permissio nto push a commit anymore :

ERROR: Permission to ringcentral/engage-digital-api-docs.git denied to GCorbel.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Is it possible to give me them back ?

@DrissTM
Copy link
Contributor

DrissTM commented Mar 7, 2025

unfortunately we can't, please create a fork and open a pull request. you might have created this PR before everyone lost access to the RC org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienChaynes FabienChaynes FabienChaynes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GCorbel @DrissTM @FabienChaynes