Skip to content

Conversation

@erfanimani
Copy link
Collaborator

@erfanimani erfanimani commented Mar 16, 2021

@scottsb
Copy link

scottsb commented Jan 5, 2022

I take it the purpose here is to gain the benefit of Laminas's more nuanced base64 encoding that is sensitive to line lengths? Is that right?

@erfanimani
Copy link
Collaborator Author

Hmm, I can't remember exactly what the technical issue was, but the commit on my client project is "Fixed attachments breaking emails".

I remember that adding attachments to emails prevented this from working. Magento doesn't use attachments out of the box I believe, but there was a custom form module that added uploaded files as email attachments.

Reverted back to the original approach with an added conditional
statement to check for Laminas Mime Part.

This way both Amasty Form attachments and Fooman order PDF attachments
work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants