Add Credentials and PermissionedDomain tx Support#1118
Merged
Conversation
## High Level Overview of Change Fix typo for website in english translation ### Context of Change Bug introduced in #1056 ### Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [ ] Translation Updates - [ ] Release ### TypeScript/Hooks Update - [ ] Updated files to React Hooks - [ ] Updated files to TypeScript
achowdhry-ripple
changed the title
achowdhry-ripple
changed the title
mvadari
reviewed
Jan 14, 2025
src/containers/shared/components/Transaction/CredentialAccept/Simple.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
Jan 14, 2025
src/containers/shared/components/Transaction/CredentialAccept/index.ts
Outdated
Show resolved
Hide resolved
achowdhry-ripple
changed the title
Collaborator
|
I would suggest creating TableDetails for these transactions as well |
achowdhry-ripple
changed the title
Collaborator
Author
|
Pipeline is broken because this references PermissionedDomain tx from xrpl.js, which hasn't been released yet. Most of everything else is ready to review, but have not been able to test in livenet dev yet (waiting on PermissionedDomain to be released in dev) |
achowdhry-ripple
changed the title
mvadari
reviewed
Jan 29, 2025
mvadari
reviewed
Jan 29, 2025
mvadari
reviewed
Jan 29, 2025
src/containers/shared/components/Transaction/CredentialAccept/Simple.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
Jan 29, 2025
src/containers/shared/components/Transaction/CredentialAccept/Simple.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
Jan 29, 2025
src/containers/shared/components/Transaction/CredentialAccept/TableDetail.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
Jan 29, 2025
src/containers/shared/components/Transaction/CredentialAccept/TableDetail.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
Jan 29, 2025
Collaborator
mvadari
left a comment
mvadari
left a comment
There was a problem hiding this comment.
Are there supposed to be empty test files?
mvadari
reviewed
Jan 29, 2025
src/containers/shared/components/Transaction/CredentialAccept/Simple.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Author
nope -- good callout, added the test jsons |
Collaborator
Author
|
Will redo the PermissionedDomain tests once its on devnet in a couple of days, hard to format right now |
pdp2121
reviewed
Jan 30, 2025
...ntainers/shared/components/Transaction/CredentialAccept/test/CredentialAcceptSimple.test.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
Jan 31, 2025
...ntainers/shared/components/Transaction/CredentialAccept/test/CredentialAcceptSimple.test.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
Jan 31, 2025
...ntainers/shared/components/Transaction/CredentialDelete/test/CredentialDeleteSimple.test.tsx
Outdated
Show resolved
Hide resolved
mvadari
reviewed
Jan 31, 2025
...hared/components/Transaction/PermissionedDomainSet/test/PermissionedDomainSetSimple.test.tsx
Show resolved
Hide resolved
mvadari
reviewed
Jan 31, 2025
| export const PermissionedDomainSetTransaction: TransactionMapping = { | ||
| Simple, | ||
| action: TransactionAction.MODIFY, | ||
| category: TransactionCategory.ACCOUNT, |
Collaborator
There was a problem hiding this comment.
This category doesn't feel right, but I'm not sure what is.
Collaborator
Author
There was a problem hiding this comment.
@pdp2121 any thoughts here? Not sure what the convention we'd follow for this is
Collaborator
There was a problem hiding this comment.
Since DID falls into ACCOUNT, I think it's fine to have Credentials fall into the same category
Collaborator
Author
There was a problem hiding this comment.
will leave this as is then
mvadari
reviewed
Jan 31, 2025
Collaborator
mvadari
left a comment
mvadari
left a comment
There was a problem hiding this comment.
Still have one empty file
Collaborator
|
Please add screenshots to the PR description |
pdp2121
reviewed
Feb 21, 2025
| {expiration && ( | ||
| <div data-test="expiration"> | ||
| <span className="label">{t('expiration')}: </span> | ||
| <span className="case-sensitive">{expiration}</span> |
Collaborator
There was a problem hiding this comment.
Expiration would be in Ripple epoch time. I think conversion and formatting are needed here
Collaborator
Author
There was a problem hiding this comment.
made the change, good callout
khancode
approved these changes
Feb 21, 2025
Contributor
khancode
left a comment
khancode
left a comment
There was a problem hiding this comment.
LGTM as far as I can tell 👍
pdp2121
approved these changes
Feb 25, 2025
mvadari
pushed a commit
that referenced
this pull request
Apr 7, 2025
## High Level Overview of Change <!-- Please include a summary/list of the changes. If too broad, please consider splitting into multiple PRs. --> Adds CredentialCreate, CredentialAccept, CredentialDelete, PermissionedDomainDelete, and PermissionedDomainSet transaction pages to the explorer. ### Context of Change <!-- Please include the context of a change. If a bug fix, when was the bug introduced? What was the behavior? If a new feature, why was this architecture chosen? What were the alternatives? If a refactor, how is this better than the previous implementation? If there is a design document for this feature, please link it here. --> https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0070d-credentials https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0080d-permissioned-domains ### Type of Change <!-- Please check relevant options, delete irrelevant ones. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [ ] Translation Updates - [ ] Release ### TypeScript/Hooks Update <!-- In an effort to modernize the codebase, you should convert the files that you work with to React Hooks and TypeScript. If this is not possible (e.g. it's too many changes, touching too many files, etc.) please explain why here. --> - [ ] Updated files to React Hooks - [ ] Updated files to TypeScript ## Before / After <!-- If just refactoring / back-end changes, this can be just an in-English description of the change at a technical level. If a UI change, screenshots should be included. --> CredentialAccept Simple <img width="1465" alt="Screenshot 2025-02-20 at 1 29 42 PM" src="https://github.com/user-attachments/assets/f4bf274a-a945-4ace-b659-d30912c39ff6" /> CredentialCreate Simple <img width="1427" alt="Screenshot 2025-02-20 at 1 31 04 PM" src="https://github.com/user-attachments/assets/42f3df6c-ef65-4432-920a-ebb9c05e9d2d" /> CredentialDelete Simple <img width="1323" alt="Screenshot 2025-02-20 at 1 31 50 PM" src="https://github.com/user-attachments/assets/6d5ec4d7-2466-4105-bc52-db705903c33e" /> CredentialAccept TableDetail <img width="992" alt="Screenshot 2025-02-20 at 1 52 37 PM" src="https://github.com/user-attachments/assets/702af132-9e7c-47f0-bf26-5530545ee949" /> CredentialCreate TableDetail <img width="1087" alt="Screenshot 2025-02-20 at 1 53 56 PM" src="https://github.com/user-attachments/assets/945bd71e-aa4e-4b08-a9a0-144c65fe38d1" /> CredentialDelete TableDetail <img width="1014" alt="Screenshot 2025-02-20 at 1 58 52 PM" src="https://github.com/user-attachments/assets/1198099b-448c-46c1-b76c-8870dc92f789" /> PermissionedDomainSet Simple <img width="1101" alt="Screenshot 2025-02-20 at 5 10 59 PM" src="https://github.com/user-attachments/assets/6258417b-25b7-4eeb-b920-aede1c3de02c" /> PermissionedDomainDelete Simple <img width="1134" alt="Screenshot 2025-02-20 at 5 11 56 PM" src="https://github.com/user-attachments/assets/f72d146f-99dd-4c1a-9de9-e38cbb50b97f" /> PermissionedDomainSet TableDetail PermissionedDomainDelete TableDetail ## Test Plan <!-- Please describe the tests that you ran to verify your changes and provide instructions so that others can reproduce. --> <!-- ## Future Tasks For future tasks related to PR. --> --------- Co-authored-by: Kenny Lei <3003853+kennyzlei@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adds CredentialCreate, CredentialAccept, CredentialDelete, PermissionedDomainDelete, and PermissionedDomainSet transaction pages to the explorer.
Context of Change
https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0070d-credentials
https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0080d-permissioned-domains
Type of Change
TypeScript/Hooks Update
Before / After
CredentialAccept Simple
CredentialCreate Simple
CredentialDelete Simple
CredentialAccept TableDetail
CredentialCreate TableDetail
CredentialDelete TableDetail
PermissionedDomainSet Simple
PermissionedDomainDelete Simple
PermissionedDomainSet TableDetail
PermissionedDomainDelete TableDetail
Test Plan