fix: handle non standard currency with decoded length of 3#1131
Merged
fix: handle non standard currency with decoded length of 3#1131
Conversation
mvadari
reviewed
Feb 19, 2025
achowdhry-ripple
approved these changes
Feb 21, 2025
intelliot
reviewed
Feb 21, 2025
intelliot
approved these changes
Feb 22, 2025
intelliot
changed the title
mvadari
pushed a commit
that referenced
this pull request
Apr 7, 2025
## High Level Overview of Change <!-- Please include a summary/list of the changes. If too broad, please consider splitting into multiple PRs. --> Handle non standard currency that decoded to 3 characters, putting prefix `Fake` to such currency. Instead of being non-standard, 3 character currency codes should use the [standard format](https://xrpl.org/docs/references/protocol/data-types/currency-formats#standard-currency-codes) if they are not "fake". ### Context of Change <!-- Please include the context of a change. If a bug fix, when was the bug introduced? What was the behavior? If a new feature, why was this architecture chosen? What were the alternatives? If a refactor, how is this better than the previous implementation? If there is a design document for this feature, please link it here. --> Resolve #1130 ### Type of Change <!-- Please check relevant options, delete irrelevant ones. --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [ ] Translation Updates - [ ] Release ## Before / After <!-- If just refactoring / back-end changes, this can be just an in-English description of the change at a technical level. If a UI change, screenshots should be included. --> ### Before <img width="941" alt="Screenshot 2025-02-19 at 4 06 15 PM" src="https://github.com/user-attachments/assets/f7df4ce9-942e-4274-b7ea-39050b976456" /> ### After <img width="952" alt="Screenshot 2025-02-19 at 4 07 00 PM" src="https://github.com/user-attachments/assets/95e46ee3-01c7-425d-a0ca-d2e584eccb76" /> --------- Co-authored-by: Elliot Lee <github.public@intelliot.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Handle non standard currency that decoded to 3 characters, putting prefix
Faketo such currency.Instead of being non-standard, 3 character currency codes should use the standard format if they are not "fake".
Context of Change
Resolve #1130
Type of Change
Before / After
Before
After