fix: Update-ko-kr (Unnatural Korean messages corrected)#1133
Merged
khancode merged 1 commit intoripple:stagingfrom Mar 19, 2025
Merged
fix: Update-ko-kr (Unnatural Korean messages corrected)#1133khancode merged 1 commit intoripple:stagingfrom
khancode merged 1 commit intoripple:stagingfrom
Conversation
khancode
approved these changes
Mar 17, 2025
pdp2121
approved these changes
Mar 18, 2025
ckeshava
pushed a commit
to ckeshava/explorer
that referenced
this pull request
Mar 20, 2025
## High Level Overview of Change - Corrected several unnatural or awkward Korean translations in the i18n files. - Ensured consistent terminology for key concepts such as “offer” vs. “제안,” and unified usage of “PayString/페이스트링.” - Aimed to improve overall clarity and user experience for Korean readers. ### Context of Change This PR addresses feedback about awkward or inconsistent Korean messages in our i18n setup. By refining these translations, we provide a more natural reading experience for Korean-speaking users. ### Type of Change <!-- Please check relevant options, delete irrelevant ones. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [x] Translation Updates - [ ] Release ### TypeScript/Hooks Update <!-- In an effort to modernize the codebase, you should convert the files that you work with to React Hooks and TypeScript. If this is not possible (e.g. it's too many changes, touching too many files, etc.) please explain why here. --> - [ ] Updated files to React Hooks - [ ] Updated files to TypeScript ## Before / After Before - Certain Korean translations were partially in English or used inconsistent terms. - Some messages sounded unnatural or ambiguous. After - Unified terminology (e.g., consistently use “제안” or “오퍼” instead of mixing). - Removed or replaced awkward phrases for smoother and more natural reading in Korean. ## Test Plan Manually checked key screens (e.g., validators list, transaction detail pages) to confirm the updated messages display correctly in Korean.
mvadari
pushed a commit
that referenced
this pull request
Apr 7, 2025
## High Level Overview of Change - Corrected several unnatural or awkward Korean translations in the i18n files. - Ensured consistent terminology for key concepts such as “offer” vs. “제안,” and unified usage of “PayString/페이스트링.” - Aimed to improve overall clarity and user experience for Korean readers. ### Context of Change This PR addresses feedback about awkward or inconsistent Korean messages in our i18n setup. By refining these translations, we provide a more natural reading experience for Korean-speaking users. ### Type of Change <!-- Please check relevant options, delete irrelevant ones. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [x] Translation Updates - [ ] Release ### TypeScript/Hooks Update <!-- In an effort to modernize the codebase, you should convert the files that you work with to React Hooks and TypeScript. If this is not possible (e.g. it's too many changes, touching too many files, etc.) please explain why here. --> - [ ] Updated files to React Hooks - [ ] Updated files to TypeScript ## Before / After Before - Certain Korean translations were partially in English or used inconsistent terms. - Some messages sounded unnatural or ambiguous. After - Unified terminology (e.g., consistently use “제안” or “오퍼” instead of mixing). - Removed or replaced awkward phrases for smoother and more natural reading in Korean. ## Test Plan Manually checked key screens (e.g., validators list, transaction detail pages) to confirm the updated messages display correctly in Korean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
This PR addresses feedback about awkward or inconsistent Korean messages in our i18n setup. By refining these translations, we provide a more natural reading experience for Korean-speaking users.
Type of Change
TypeScript/Hooks Update
Before / After
Before
After
Test Plan
Manually checked key screens (e.g., validators list, transaction detail pages) to confirm the updated messages display correctly in Korean.