Conversation
mvadari
changed the title
mvadari
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Explorer configuration to use Node v22 and npm v10 to keep up with security support and improvements. The key changes include:
- Updating Node version references in CI workflows to 22.x.
- Modifying README.md to reflect changes in the required Node version.
- Adjusting caching keys and setup steps in GitHub Actions to use the new Node version.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updated Node version requirement (currently shows v20 instead of v22) |
| .github/workflows/nodejs.yml | Replaced Node version references with an environment variable set to 22.x and updated caching keys accordingly |
Files not reviewed (2)
- .nvmrc: Language not supported
- package.json: Language not supported
pdp2121
approved these changes
Apr 8, 2025
intelliot
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR updates the Explorer to use Node v22 and npm v10 (it currently uses Node v18 and npm v9).
Context of Change
Node 18 security support ends in a month.
Type of Change
TypeScript/Hooks Update
N/A
Test Plan
CI passes.
Note: technically this PR doesn't pass the required tests, but those tests should be changed to match these once this PR gets approval.
Future Tasks
Update the deploy scripts accordingly.