Conversation
## High Level Overview of Change Fix typo for website in english translation ### Context of Change Bug introduced in #1056 ### Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [ ] Translation Updates - [ ] Release ### TypeScript/Hooks Update - [ ] Updated files to React Hooks - [ ] Updated files to TypeScript
ckeshava
reviewed
Jul 30, 2025
Comment on lines
+50
to
+51
| await getLedgerEntry(rippledContext, id) | ||
| return 'entry' |
Contributor
There was a problem hiding this comment.
Is there any way we can cache the result of this method invocation? It feels wasteful to invoke this API only for the purpose of checking if the hash pertains to a transaction, ledger-entry (or) an NFT.
Collaborator
Author
There was a problem hiding this comment.
That change should probably be made in a separate PR
src/rippled/lib/rippled.ts
Outdated
Comment on lines
96
to
98
| if (resp.error === 'lgrNotFound') { | ||
| throw new Error('invalid ledger index/hash', 400) | ||
| } |
Contributor
There was a problem hiding this comment.
This RPC command always fetches the last validated ledger. This error cannot possibly occur.
Collaborator
Author
There was a problem hiding this comment.
Better to have an extra error handler and not need it - no need to delete it IMO
mrbeastmcnasty
approved these changes
Nov 12, 2025
JSTONE1111
approved these changes
Dec 26, 2025
JSTONE1111
approved these changes
Dec 26, 2025
JSTONE1111
approved these changes
Jan 3, 2026
JSTONE1111
approved these changes
Feb 6, 2026
JSTONE1111
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds a new type of page for ledger entries/objects. For now it just has a default page that shows all the fields of an object, but over time we can add special ones.
It also:
Detailedtab metadata breakdownAccountpage if the object is an accountContext of Change
Type of Change
TypeScript/Hooks Update
Before / After
Test Plan