Support for Permissioned DEX XLS-81d#1208
Merged
ckeshava merged 6 commits intoripple:stagingfrom Jul 25, 2025
Merged
Conversation
Patel-Raj11
reviewed
Jul 18, 2025
src/containers/shared/components/Transaction/OfferCreate/parser.ts
Outdated
Show resolved
Hide resolved
Collaborator
Contributor
Author
pdp2121
reviewed
Jul 24, 2025
| "offer_create_desc_line_1": "<1><0>{{account}}</0></1> は、<5><0>{{takerPays}}</0><1><0>{{currency}}</0></1></5> を取得するために、<3><0>{{takerGets}}</0><1><0>{{currency}}</0></1></3> を支払うオファーを作成しました。", | ||
| "offer_create_desc_line_2": "このオファーの変換レートは", | ||
| "offer_create_desc_line_3": "トランザクションによって、アカウントの次のオファー番号も取り消されます :", | ||
| "offer_create_desc_line_5": "このオファーは許可ドメインに適用されます", |
Collaborator
There was a problem hiding this comment.
You don't have to input translation for languages other than English. Can just put null and specialized community contributors will fill them in later
Contributor
Author
There was a problem hiding this comment.
ok, I'll that iin mind for the next feature. However, for this PR, I verified that all the translations are accurate (with Google Translate) software.
Do you still want to remove them? I'd prefer to keep them.
pdp2121
reviewed
Jul 24, 2025
| </span> | ||
| )} | ||
| {fields.DomainID && ( | ||
| <span> pertaining to the Permissioned Domain: {fields.DomainID}</span> |
Collaborator
There was a problem hiding this comment.
Needs translation hook for this
pdp2121
approved these changes
Jul 25, 2025
Contributor
Author
|
Thank you for the reviews @pdp2121 @Patel-Raj11 |
pdp2121
pushed a commit
that referenced
this pull request
Oct 8, 2025
This PR implements support for the [Permissioned DEX (XLS-81D)](https://github.com/XRPLF/XRPL-Standards/blob/56ba122be9f127c940fd37d433faaa2de91a4eb6/XLS-0081d-permissioned-dex/README.md). The rippled C++ PR can be [found here](https://github.com/XRPLF/rippled/pull/5404/files). This is [the relevant PR](XRPLF/xrpl.js#3032) for xrpl.js client library.
pdp2121
pushed a commit
that referenced
this pull request
Oct 8, 2025
This PR implements support for the [Permissioned DEX (XLS-81D)](https://github.com/XRPLF/XRPL-Standards/blob/56ba122be9f127c940fd37d433faaa2de91a4eb6/XLS-0081d-permissioned-dex/README.md). The rippled C++ PR can be [found here](https://github.com/XRPLF/rippled/pull/5404/files). This is [the relevant PR](XRPLF/xrpl.js#3032) for xrpl.js client library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR implements support for the Permissioned DEX (XLS-81D). The rippled C++ PR can be found here. This is the relevant PR for xrpl.js client library.
Type of Change
Codebase Modernization
The affected filed already make use of Typescript test frameworks (jest).
Before / After
Simple-view of thePaymenttransaction withDomainID. Here is the display of the currently-deployed devnet.Detailedview of thePaymenttransaction. The above link to the currently-deployed devnet will provide you the before/after diff for this PR.Detailedview of theOfferCreatetransaction with thetfHybridflag. This is the link to the transaction in the current version of the devnet-explorer.Simple-view of the aboveOfferCreatetransaction:Visualization of the changes to the
DirectoryNodein the transaction-metadata:This PR provides support for XLS-85d Permissioned Domains in the Explorer. If DomainID field is included in the Payment and OfferCreate transactions, then this PR provides support for rendering that information.
Test Plan
Appropriate unit tests have been included.