Conversation
Collaborator
Author
|
It's failing the LedgersPage tests, which I haven't even touched in this PR. Going to wait for those to be refactored. These tests are failing because for some reason, in |
Collaborator
Author
|
This might be relevant for fixing the TS issues: vitest-dev/vitest#664 |
Collaborator
Author
|
Closing in favor of the cleaner version: #945 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Waiting for the Streams refactor, because the tests are failing there for some reason
Type of Change
TypeScript/Hooks Update
Before / After
Test Plan