Skip to content

Conversation

@pdp2121
Copy link
Collaborator

@pdp2121 pdp2121 commented Mar 8, 2024

High Level Overview of Change

Use node 18 and 20 and deprecate unmaintained node versions (14 and 16).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

@pdp2121 pdp2121 marked this pull request as draft March 8, 2024 20:33
@pdp2121 pdp2121 requested a review from mvadari March 8, 2024 20:33
@pdp2121 pdp2121 changed the title remove unmaintained nodes Update Node version Mar 8, 2024
@pdp2121 pdp2121 requested a review from JST5000 March 8, 2024 20:51
@pdp2121 pdp2121 marked this pull request as ready for review March 8, 2024 20:51
@ckeshava
Copy link
Contributor

This PR will benefit from the changes in this other PR: #320

@mvadari
Copy link
Collaborator

mvadari commented Apr 10, 2025

The deploy pipeline needs to be upgraded in order for this to be done

@pdp2121
Copy link
Collaborator Author

pdp2121 commented Apr 10, 2025

PR for pipeline:
https://github.com/xpring-eng/vhs-deploy/pull/23

@pdp2121
Copy link
Collaborator Author

pdp2121 commented Apr 21, 2025

Tested on staging. Things look good to me

@pdp2121 pdp2121 merged commit 76a5c40 into main Apr 21, 2025
2 checks passed
@pdp2121 pdp2121 deleted the update-node-version branch April 21, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants