Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 1, 2024

Bumps xrpl from 2.13.0 to 4.0.0.

Release notes

Sourced from xrpl's releases.

[email protected]

What's Changed

New Contributors

Full Changelog: https://github.com/XRPLF/xrpl.js/compare/@​xrplf/isomorphic@​[email protected]

[email protected]

What's Changed

New Contributors

Full Changelog: https://github.com/XRPLF/xrpl.js/compare/[email protected]@3.1.0

[email protected]

What's Changed

Migration Guide

BREAKING CHANGES

  • Bump typescript to 5.x
  • Remove Node 14 support
  • Remove crypto polyfills, create-hash, elliptic, hash.js, and their many dependencies in favor of @noble/hashes and @nobel/curves
  • Remove bip32 and bip39 in favor of @scure/bip32 and @scure/bip39
  • Remove assert dependency. If you were catching AssertionError you need to change to Error
  • Configuring a proxy:
    • Instead of passing various parameters on the ConnectionsOptions you know specify the agent parameter. This object can use be created by libraries such as https-proxy-agent or any that implements the http.Agent.
    • This was changed to both support the latest https-proxy-agent and to remove the need to include the package in bundlers. Tests will still be done using https-proxy-agent and only tested in a node environment which was the only way it was previously supported anyway
  • Remove BroadcastClient which was deprecated
  • Uses @xrplf/secret-numbers instead of xrpl-secret-numbers
  • Improve key algorithm detection. It will now throw Errors with helpful messages
  • Move authorizeChannel from wallet/signer to wallet/authorizeChannel to solve a circular dependency issue.
  • When using a bundler you must remove the mapping of ws to WSWrapper. ex. ws: 'xrpl/dist/npm/client/WSWrapper'. See [../UNIQUE_STEPS](https://github.com/XRPLF/xrpl.js/blob/HEAD/Unique Steps) for the new, much smaller, configs.
  • Transaction type has been redefined to include all transactions and SubmittableTransaction was created to define the old value. The following functions which only handle transactions to be submitted now use SubmittableTransaction:
    • Client.autofill

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [xrpl](https://github.com/XRPLF/xrpl.js) from 2.13.0 to 4.0.0.
- [Release notes](https://github.com/XRPLF/xrpl.js/releases)
- [Changelog](https://github.com/XRPLF/xrpl.js/blob/main/HISTORY.md)
- [Commits](https://github.com/XRPLF/xrpl.js/compare/[email protected]@4.0.0)

---
updated-dependencies:
- dependency-name: xrpl
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 1, 2024
@mvadari
Copy link
Collaborator

mvadari commented Aug 1, 2024

A type error that should be easy to resolve:

The types of 'result.ledger' are incompatible between these types.
    Type 'LedgerBinary | LedgerCorrected' is not assignable to type 'LedgerBinary'.
      Type 'LedgerCorrected' is not assignable to type 'LedgerBinary'.
        Types of property 'accountState' are incompatible.
          Type 'LedgerEntry[] | undefined' is not assignable to type 'string[] | undefined'.
            Type 'LedgerEntry[]' is not assignable to type 'string[]'.
              Type 'LedgerEntry' is not assignable to type 'string'.
                Type 'AccountRoot' is not assignable to type 'string'.

@pdp2121 pdp2121 requested review from ckniffen and pdp2121 December 12, 2024 21:01
@pdp2121 pdp2121 merged commit 75694a2 into main Dec 12, 2024
4 checks passed
@pdp2121 pdp2121 deleted the dependabot/npm_and_yarn/xrpl-4.0.0 branch December 12, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants