feat: Use feature for amendment name #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
reviewed
Dec 19, 2024
ckniffen
reviewed
Dec 19, 2024
ckniffen
reviewed
Dec 19, 2024
ckniffen
reviewed
Dec 19, 2024
ckniffen
reviewed
Dec 19, 2024
src/shared/database/amendments.ts
Outdated
| if ('result' in featureResponse) { | ||
| const feature = featureResponse.result[amendment_id] | ||
| amendmentIDs.set(amendment_id, { | ||
| name: feature.name, |
Collaborator
There was a problem hiding this comment.
Is there more that should be stored?
Collaborator
Author
There was a problem hiding this comment.
There are only these fields in feature, of which only name is useful for us.
enabled | Boolean | Whether this amendment is currently enabled in the latest ledger.
name | String | (May be omitted) The human-readable name for this amendment, if known.
supported | Boolean | Whether the server knows how to apply this amendment. If this field is set to false (the server does not know how to apply this amendment) and enabled is set to true (this amendment is enabled in the latest ledger), this amendment may cause your server to be amendment blocked.
ckniffen
reviewed
Dec 19, 2024
ckniffen
reviewed
Dec 19, 2024
ckniffen
reviewed
Dec 19, 2024
achowdhry-ripple
approved these changes
Dec 20, 2024
Collaborator
achowdhry-ripple
left a comment
achowdhry-ripple
left a comment
There was a problem hiding this comment.
LGTM -- for code readability would recommend differentiating between fetch methods and ones that actually set the cache as well, but logic looks solid otherwise
Collaborator
Author
Fixed that in the latest commit |
anissa-ripple
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Resolve: #278
Context of Change
Missing new amendments due to the change in rippled code structure to parse name:
Type of Change
Before / After
Data should show up:
VHS is lacking tests at the moment. There will be a separate ticket to add comprehensive tests throughout the code