Skip to content

Conversation

@pdp2121
Copy link
Collaborator

@pdp2121 pdp2121 commented Feb 4, 2025

High Level Overview of Change

UNL v2 was deployed to devnet in the most recent reset. This introduces a field called blobs_v2 which is an array containing multiple blobs. The VHS needs to be fixed to capture this change.

This fix has been deployed to staging:
https://stg.validator.history.xpring.dev/v1/network/validators/dev
And also could be checked at:
https://dev.dev.explorer.xpring.dev/network/validators

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Copy link
Collaborator

@achowdhry-ripple achowdhry-ripple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test?

@pdp2121 pdp2121 requested a review from mvadari February 13, 2025 20:05
@pdp2121
Copy link
Collaborator Author

pdp2121 commented Feb 13, 2025

Can we add a test?

I just added a test

@pdp2121 pdp2121 merged commit 8962327 into main Feb 27, 2025
4 checks passed
@pdp2121 pdp2121 deleted the fix-unl-dev branch February 27, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants