add debug log statements #316
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
from the log, are we able to tell for which network it is calculating the score |
ckeshava
reviewed
Apr 10, 2025
| @@ -233,6 +240,12 @@ class Chains { | |||
| if (skipped > 1 && skipped < 20) { | |||
| chainWithThisValidator.incomplete = true | |||
| addLedgerToChain(ledger, chainWithThisValidator) | |||
| } else { | |||
| log.info( | |||
| `DebugSkipped2:${`${next}:${ledger.ledger_index}`}:${Array.from( | |||
There was a problem hiding this comment.
It might be easier to debug this data with chainWithThisValidator.id. The set of validators is probably identifying the public keys, which are not very informative (for human eyes).
ckeshava
reviewed
Apr 10, 2025
| @@ -153,6 +153,8 @@ class Agreement { | |||
| for (const chain of agreementChains) { | |||
| const ledger_hashes = chain.ledgers | |||
|
|
|||
| log.info(`Debug: ${chain.id}:${Array.from(chain.validators).join(',')}`) | |||
There was a problem hiding this comment.
These are useful debug logs. I would like them in the code base.
There was a problem hiding this comment.
Improved version of this log statement is merged in this PR
https://github.com/ripple/validator-history-service/pull/328/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
Before / After
Test Plan