fetch network info from the validation #329
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Patel-Raj
reviewed
Apr 3, 2025
| .first() | ||
| const validationNetwork = | ||
| validationNetworkDb?.networks ?? validationData.networks | ||
| const validationNetwork = validationData.networks ?? networks |
There was a problem hiding this comment.
As per #328 (comment)
I think we should fallback to the in-memory cache -> database to get the network as you suggested here #328 (comment)
There was a problem hiding this comment.
Yes, that is also an acceptable solution. However, I'm wary of the larger untested code changes in that PR. I will also note one other (albeit rare) possibility:
The in-memory cache does not have any "invalidation scheme". The network corresponding to a validator's public_key could be changed after its admission into the in-memory cache. However, this change will not be registered until at least CM_INTERVAL. This would be a very rare occurence, but it is something we need to consider for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The PR aims to reduce reading from the
validatorstable. Since validation is the most recent source of truth, it must have the latest information about thenetwork. If that field is not present, we can rely on the web-socket connection's metadata.Context of Change
Type of Change
Before / After
Test Plan
Tests need to be added to verify the correctness. Furthermore, we need to measure the impact on the db performance with this change. This is planned for a future release.