-
Notifications
You must be signed in to change notification settings - Fork 10
Expose WebSocket connection count as prometheus metrics and some refactors #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
32fc48d
1d69fc6
cad1187
1877417
339b35e
c38b316
3c69b8a
f64b49a
938536b
552c03a
2e99a3f
cd06b8f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,6 +82,17 @@ const info = { | |
example: | ||
'https://data.xrpl.org/v1/network/amendments/vote/{network}/{identifier}', | ||
}, | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this is for internal use I don't think we need to expose it in info There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even if its for internal use, I feel a good documentation is helpful for future development. @pdp2121 Are there any concerns about privacy/security? Are there are disadvantages to exposing it? |
||
action: 'Get total number of connected rippled nodes.', | ||
route: '/v1/health', | ||
example: 'https://data.xrpl.org/v1/health', | ||
}, | ||
{ | ||
action: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
'Get total number of connected rippled nodes for a particular network in prometheus exposition format.', | ||
route: '/v1/metrics/{network}', | ||
example: 'https://data.xrpl.org/v1/metrics/{network}', | ||
}, | ||
], | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this to be env variable instead of a constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To remain consistent with other database configs and having it as env variable enables us to change it without changing the code and have a different value for staging, dev etc.