feat: add Homebrew tap tracking - #235
Merged
Merged
Conversation
Xarianne
force-pushed
the
brew-tap-tracking
branch
from
August 4, 2026 08:04
bb795f3 to
68dbd6e
Compare
ripytide
force-pushed
the
brew-tap-tracking
branch
from
August 9, 2026 17:32
1316b97 to
d54b121
Compare
Owner
|
Looks good, thanks! I rebased your PR on main so that it could be merged |
ripytide
marked this pull request as ready for review
August 9, 2026 17:35
Contributor
Author
|
Awesome :) Thanks for the merge! |
Owner
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds declarative Homebrew tap management to the
brewbackend, matching the existing repo support fordnfandflatpak.Usage
In a group file, declare taps under
brew.repos:metapac syncwill tap and trust any missing repos.metapac cleanwill untap and untrust any repos not listed.metapac unmanagedwill report taps that are not declared in any group file.Implementation
get_installed_repos()now runsbrew tapto discover existing taps.add_repos()runsbrew tap <tap>andbrew trust --tap <tap>. Trusting is required because recent Homebrew versions refuse to load casks from untrusted taps.remove_repos()runsbrew untap <tap>andbrew untrust --tap <tap>to keep trust state in sync.Dependencies
This PR depends on #234 (which you just merged), which fixes
metapac cleanso packages are removed before repos. Without that fix,brew untapfails because Homebrew refuses to untap a tap that still contains installed casks or formulae:Testing
Tested locally with
cargo run --:metapac unmanagedcorrectly detected a tap not declared in group files.ublue-os/tapandaurora-wallpapers.metapac sync --no-confirmtapped, trusted, and installed successfully.metapac clean --no-confirmuninstalled the package first, then untapped and untrusted the tap.Checklist
cargo checkpassescargo fmtpassescargo clippy --all-targets -- -D warningspasses after fix: clean packages before repos #234 is merged