WEB3-513: contracts: dependency cleanups#654
Draft
Wollac wants to merge 5 commits into
Draft
Conversation
github-actions
Bot
changed the title
nategraf
reviewed
Aug 5, 2025
nategraf
left a comment
nategraf
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. Thank you for working taking care of this.
Comment on lines
-20
to
-25
| /// Re-export of [alloy], provided to ensure that the correct version of the types used in the | ||
| /// public API are available in case multiple versions of [alloy] are in use. | ||
| /// | ||
| /// Because [alloy] is a v0.x crate, it is not covered under the semver policy of this crate. | ||
| pub use alloy; | ||
|
|
Contributor
There was a problem hiding this comment.
I don't think we should remove this, because it might break downstream users and I think this is actually still helpful.
nategraf
previously approved these changes
Aug 5, 2025
Contributor
|
I like the idea of bringing in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetVerifierServicebehind featurealloyhas been released in v1, so there is no immediate need anymore to expose it