Skip to content

doc team edits#16

Closed
kersten1 wants to merge 2 commits intomainfrom
kersten1-patch-1
Closed

doc team edits#16
kersten1 wants to merge 2 commits intomainfrom
kersten1-patch-1

Conversation

@kersten1
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Kersten Richter <kersten@riscv.org>
Signed-off-by: Kersten Richter <kersten@riscv.org>
cite:[IOMMU-SPEC] and the relationship between the IO topology and the IOMMU in
ACPI cite:[ACPI-SPEC] based RISC-V platforms. The RIMT identifies which
components are behind IOMMU and how they are connected together. RISC-V IOMMU
components are backing IOMMU and how they are connected together. RISC-V IOMMU
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"behind" is more directional to me so I suggest "backing". Please let me know if you want to discuss this farther. Maybe there is a third word that is better?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!. But I think behind is correct since it is actually directional that devices are behind the IOMMU from CPU point of view. Backing is not correct.

@kersten1
Copy link
Copy Markdown
Contributor Author

Very minor grammar comments. Whenever you use "which", it must have a comma before it. "which" is used for extra information that isn't really required. "that" is information that is important to the sentence. Otherwise, pretty clear and straightforward. Let me know if you want to discuss any of this. These are suggestions and not red pen marks that must be followed.

@vlsunil
Copy link
Copy Markdown
Collaborator

vlsunil commented Feb 19, 2025

@kersten1 I have taken all changes except backing vs behind as part of the PR #21. So, closing this PR. Thanks for your help!.

@vlsunil vlsunil closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants