Update assembler relocation function related descriptions#77
Open
hirooih wants to merge 3 commits intoriscv-non-isa:mainfrom
Open
Update assembler relocation function related descriptions#77hirooih wants to merge 3 commits intoriscv-non-isa:mainfrom
hirooih wants to merge 3 commits intoriscv-non-isa:mainfrom
Conversation
|
I would prefer to see the LA and LI operations described along the lines of: li rd,constant Note that the LUI will sign-extend the 20-bit value on RV64 & RV128 systems. |
ref. - RISC-V Unprivileged ISA V20191213, chapter 25 - gcc manual https://sourceware.org/binutils/docs/as/RISC_002dV_002dModifiers.html
62250eb to
571f229
Compare
Author
|
Thank you for your suggestion. And I also found I misunderstood the definition of %pcrel_lo(label). I fixed it, too. |
571f229 to
45d77ea
Compare
Author
I did not fix the psedoinstructions table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the table of A listing of standard RISC-V pseudoinstructions, for example, the base Instruction for
la rd, symbolis described as:In The RISC-V Instruction Set Manual Volume I: Unprivileged ISA, v20191213, Chapter 25 RISC-V Assembly Programmer’s Handbook (in the latest version the chapter is deleted), it is described as;
The current description in this manual is wrong. It does not consider the signed immediate offset.
This PR proposes:
Note that I could not find clear description of
%tprel_*and%tls_*. So they maybe still wrong. Please review them carefully.