Introduce vendor prefix for Rivos custom extensions#72
Introduce vendor prefix for Rivos custom extensions#72cmuellner merged 2 commits intoriscv-non-isa:mainfrom
Conversation
This change reserves the vendor prefix "rv." for Rivos's custom extensions. Signed-off-by: Philip Reames <preames@rivosinc.com>
|
Might "rv" perhaps get confused with official "RISC-V" standard extensions? |
The mnemonics for standard extensions are not prefixed. |
I appreciate that, but isn't it possible that some casual observers won't know that and might mistakenly assume that "rv" prefixed extensions might be official/standard/non-proprietary RISC-V? Especially since "RV" is so widely used as an informal way to refer to RISC-V features in general. An easy way to eliminate the possibility of such confusion might be by using a different prefix here? |
|
We talked about this in the SIG Toolchain call today. I acknowledge the potential for confusion with an Where it might cause confusion is in the intrinsic names. I stated that I wouldn't block this PR, but I'd like to hear opinions from GCC and LLVM maintainers on this. |
|
The consensus in the RISC-V LLVM sync-up call (lead by @asb) was to accept this. @kito-cheng, any opinion here? |
I was also hesitate about that may confused by riscv as well, but that sound reasonable with those two reasons. |
|
So yeah, LGTM :) |
Signed-off-by: Philip Reames <preames@rivosinc.com>
|
FYI, triggered by the discussion here and in the LLVM reviews, we have changed the specification for the instructions (https://github.com/rivosinc/rivos-custom-extensions) to use the "ri." prefix instead of "rv." To date, only experimental support has landed in LLVM and we just changed that over as well. @kito-cheng If you're good with the change, could you land the new version? |
|
Related LLVM PR: llvm/llvm-project#128761 |
|
LLVM merged the |
This change reserves the vendor prefix "ri." for Rivos's custom extensions.