Skip to content

Add more SiFive extensions to List of vendor extensions#74

Closed
topperc wants to merge 1 commit intoriscv-non-isa:mainfrom
topperc:pr/sifive-extensions
Closed

Add more SiFive extensions to List of vendor extensions#74
topperc wants to merge 1 commit intoriscv-non-isa:mainfrom
topperc:pr/sifive-extensions

Conversation

@topperc
Copy link
Copy Markdown
Contributor

@topperc topperc commented Feb 18, 2025

Two extensions start with XSiFive for historical documentation reasons. Newer extensions use XSF.

Two extensions start with XSiFive for historical documentation reasons.
Newer extensions use XSF.
|OpenHW | Xcvmac | 1.0.0 | https://github.com/openhwgroup/cv32e40p/blob/dev/docs/source/instruction_set_extensions.rst[CORE-V Instruction Set Extensions]
|OpenHW | Xcvmem | 1.0.0 | https://github.com/openhwgroup/cv32e40p/blob/dev/docs/source/instruction_set_extensions.rst[CORE-V Instruction Set Extensions]
|OpenHW | Xcvsimd | 1.0.0 | https://github.com/openhwgroup/cv32e40p/blob/dev/docs/source/instruction_set_extensions.rst[CORE-V Instruction Set Extensions]
|SiFive | XSiFivecdiscarddlone | 1.0 | https://sifive.cdn.prismic.io/sifive/767804da-53b2-4893-97d5-b7c030ae0a94_s76mc_core_complex_manual_21G3.pdf[SiFive S76-MC Core Complex Manual]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I open the referenced document, I can't find the term "XSiFivecdiscarddlone" in there.

Copy link
Copy Markdown

@TommyMurphyTM1234 TommyMurphyTM1234 Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I open the referenced document, I can't find the term "XSiFivecdiscarddlone" in there.

Isn't this it?

3.4.2 Cache Maintenance Operations

The data cache supports CFLUSH.D.L1 and CDISCARD.D.L1. The instruction CFLUSH.D.L1
cleans and invalidates the specified line or all cache lines. The instruction CDISCARD.D.L1 invalidates the specified line or all cache lines.
These custom instructions are further described in Chapter 6.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those are the instructions. The extension name didn't make it into that document, but it's name has been used in SiFive's internal toolchain for several years.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this table should define the name and version of vendor extensions. The idea of the table is to have an index.

My preferred solution would be for SiFive to host a document where the extension is defined (name, version, instructions, CSRs). That's the bar we also had for other extensions in the table.

@topperc topperc closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants