Add instruction limit #1828
Merged
Add instruction limit #1828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I wonder if the desired behavior can be achieved through using the achieve the same effect? |
Author
|
Doesn't seem to - it does stop the simulation but it just drops you into the REPL rather than exiting. In any case it's a far less convenient and discoverable interface. |
Author
|
Any chance of a review for this? |
aswaterman
reviewed
Feb 6, 2025
Collaborator
aswaterman
left a comment
aswaterman
left a comment
There was a problem hiding this comment.
The changes to the control flow make me a little nervous, but they are probably harmless. @jerryz123?
aswaterman
reviewed
Feb 6, 2025
aswaterman
reviewed
Feb 6, 2025
Timmmm
force-pushed
the
instruction_limit
branch
from
a965833 to
784679a
Compare
aswaterman
approved these changes
Feb 7, 2025
Collaborator
|
Looks like you need to update the ci-tests to account for the API change. |
Adds an optional --instructions=N CLI argument which will stop the simulation after N instructions. This is useful for benchmarking and profiling and sometimes debugging.
Timmmm
force-pushed
the
instruction_limit
branch
from
784679a to
fdbcde2
Compare
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional --instructions=N CLI argument which will stop the simulation after N instructions.
This is useful for benchmarking and profiling and sometimes debugging.